From 2c9e4fd9fafc605a9bf191c14ed1075b7489b693 Mon Sep 17 00:00:00 2001 From: captainhook <16797541+captainhook@users.noreply.github.com> Date: Sun, 12 Oct 2025 18:01:34 +0100 Subject: [PATCH] Enhance build script to support multi-platform builds and improve Docker build experience (#262) * Enhance build script to support multi-platform builds and improve Docker build experience * Update build.sh Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Correct value for --platform argument --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- build.sh | 40 ++++++++++++++++++++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/build.sh b/build.sh index 58d5294..39e3754 100755 --- a/build.sh +++ b/build.sh @@ -6,6 +6,25 @@ BW_VERSION=$(curl -sL https://go.btwrdn.co/bw-sh-versions | grep '^ *"'coreVersi echo "Building BitBetter for BitWarden version $BW_VERSION" +# Enable BuildKit for better build experience and to ensure platform args are populated +export DOCKER_BUILDKIT=1 +export COMPOSE_DOCKER_CLI_BUILD=1 + +# Determine host architecture to use as default BUILDPLATFORM / TARGETPLATFORM if not supplied. +# Allow override via environment variables when invoking the script. +HOST_UNAME_ARCH=$(uname -m 2>/dev/null || echo unknown) +case "$HOST_UNAME_ARCH" in + x86_64|amd64) DEFAULT_ARCH=amd64 ;; + aarch64|arm64) DEFAULT_ARCH=arm64 ;; + armv7l|armv7) DEFAULT_ARCH=arm/v7 ;; + *) DEFAULT_ARCH=amd64 ;; +esac + +: "${BUILDPLATFORM:=linux/${DEFAULT_ARCH}}" +: "${TARGETPLATFORM:=linux/${DEFAULT_ARCH}}" + +echo "Using BUILDPLATFORM=$BUILDPLATFORM TARGETPLATFORM=$TARGETPLATFORM" + # If there aren't any keys, generate them first. [ -e "$DIR/.keys/cert.cert" ] || "$DIR/.keys/generate-keys.sh" @@ -19,8 +38,25 @@ new_thumbprint=$(openssl x509 -inform DER -fingerprint -noout -in $DIR/.keys/cer sed -i -e "s/$old_thumbprint/$new_thumbprint/g" $DIR/server/src/Core/Billing/Services/Implementations/LicensingService.cs cp $DIR/.keys/cert.cert $DIR/server/src/Core/licensing.cer -docker build --no-cache --label com.bitwarden.product="bitbetter" $DIR/server -f $DIR/server/src/Api/Dockerfile -t bitbetter/api -docker build --no-cache --label com.bitwarden.product="bitbetter" $DIR/server -f $DIR/server/src/Identity/Dockerfile -t bitbetter/identity +docker build \ + --no-cache \ + --platform "$TARGETPLATFORM" \ + --build-arg BUILDPLATFORM="$BUILDPLATFORM" \ + --build-arg TARGETPLATFORM="$TARGETPLATFORM" \ + --label com.bitwarden.product="bitbetter" \ + -f $DIR/server/src/Api/Dockerfile \ + -t bitbetter/api \ + $DIR/server + +docker build \ + --no-cache \ + --platform "$TARGETPLATFORM" \ + --build-arg BUILDPLATFORM="$BUILDPLATFORM" \ + --build-arg TARGETPLATFORM="$TARGETPLATFORM" \ + --label com.bitwarden.product="bitbetter" \ + -f $DIR/server/src/Identity/Dockerfile \ + -t bitbetter/identity \ + $DIR/server docker tag bitbetter/api bitbetter/api:latest docker tag bitbetter/identity bitbetter/identity:latest